Skip to content

style: refine app launcher card layout#12404

Merged
ssongliu merged 1 commit intodev-v2from
fix/home-app-card-style
Apr 3, 2026
Merged

style: refine app launcher card layout#12404
ssongliu merged 1 commit intodev-v2from
fix/home-app-card-style

Conversation

@ssongliu
Copy link
Copy Markdown
Member

@ssongliu ssongliu commented Apr 2, 2026

Refs #11591

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Apr 2, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6d3c3d35b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +105 to +107
@click="routerToName('AppInstalled')"
>
{{ $t('home.dir') }}
{{ $t('tabs.more') }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep app-specific actions in launcher card

This change replaces the app-specific action entry point with a generic AppInstalled navigation, so from the launcher card users can no longer directly open the selected app’s directory or website URL (those controls were removed in this commit). For installed/website apps, this is a functional regression: the action now loses app context and forces users to re-find the app in another page instead of acting on the current card.

Useful? React with 👍 / 👎.

@ssongliu ssongliu merged commit 4b3f8a9 into dev-v2 Apr 3, 2026
2 of 3 checks passed
@ssongliu ssongliu deleted the fix/home-app-card-style branch April 3, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants